Refactor tests when moving to k8s.io/client-go v0.26.0 #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
…k_test.go Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
dttung2905
force-pushed
the
client-crud
branch
from
c702a81
to
059e247
Compare
JorTurFer
reviewed
Jan 14, 2023
JorTurFer
reviewed
Jan 14, 2023
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
zroubalik
reviewed
Jan 16, 2023
zroubalik
reviewed
Jan 16, 2023
…tream() Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
3 tasks
…incompatibility Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
|
/run-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
This is the first PR to resolve #4013. There will be a followed up PR on this issue as this is a relatively big one and I would like to break it down into smaller pieces
A few things I have done:
k8s.io/client-go v0.26.0as it uses ginkgov2 (release note)BeforeSuite(). I take references from here Timeout on setup nodes in ginkgo v2 onsi/ginkgo#882. Although I think we might need to refactor even further but I would leave that for another MRChecklist